Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/spree 3 2 rails 5 #39

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

symarys
Copy link

@symarys symarys commented Mar 2, 2017

No description provided.

@brchristian
Copy link
Contributor

Hi @symarys, looks like you modified test case 6? We have to keep to the official Tax Cloud test specifications, as per https://github.com/spree-contrib/spree_tax_cloud/blob/master/TaxCloudImplementationVerificationGuide.pdf. The only exception would be if Tax Cloud themselves have updated their guide, in which case we should include the latest Verification Guide in the repository as well as changing the tests.

This reverts commit c8778c1.
@symarys
Copy link
Author

symarys commented Mar 3, 2017

@brchristian Thank you for the tip! It seems that the specifications changed, but at this point I cannot prove it - for the time being I reverted that commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants