Feature/spree 3 2 rails 5#39
Open
symarys wants to merge 6 commits into
Open
Conversation
Contributor
|
Hi @symarys, looks like you modified test case 6? We have to keep to the official Tax Cloud test specifications, as per https://github.com/spree-contrib/spree_tax_cloud/blob/master/TaxCloudImplementationVerificationGuide.pdf. The only exception would be if Tax Cloud themselves have updated their guide, in which case we should include the latest Verification Guide in the repository as well as changing the tests. |
This reverts commit c8778c1.
Author
|
@brchristian Thank you for the tip! It seems that the specifications changed, but at this point I cannot prove it - for the time being I reverted that commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.