This repository was archived by the owner on Feb 8, 2026. It is now read-only.
Fix the devise helper signed_in_root_path call#304
Open
wmotti wants to merge 2 commits intospree:2-4-stablefrom
Open
Fix the devise helper signed_in_root_path call#304wmotti wants to merge 2 commits intospree:2-4-stablefrom
wmotti wants to merge 2 commits intospree:2-4-stablefrom
Conversation
signed_in_root_path is a helper from devise controller so it needs to be called from controller and not from routes. Fixes spree#280
Contributor
|
@wmotti Please rebase against current master, thanks in advance 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
signed_in_root_path is a helper from devise controller
so it needs to be called from controller and not from routes.
Fixes #280