Issue #22 Allow topic auto-creation as an option #116
+12
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
britth
reviewed
Feb 10, 2022
There was a problem hiding this comment.
This looks great, thanks for the contribution @jgaviria ! One possible suggestion: what do you think about undoing the changes to the test config, and instead adding a new test in the consumer and producer tests that temporarily overrides this setting there? That way, we can continue to test default behavior?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Folks,
It would be really useful to allow topic-auto creation from both the publisher and consumer since sometimes it is a lot more complicated to do it from the Docker container.
Let me know if the code looks good or if you want any changes.