-
Notifications
You must be signed in to change notification settings - Fork 64
Allow more brod config options #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
auto_start_producers and allow_topic_auto_creation are no longer hard coded, and can be configured per client (producer or consumer).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR allows configuration of auto_start_producers and allow_topic_auto_creation options for brod clients instead of having them hard-coded, and bumps the library version to 1.28.0.
- Made
auto_start_producersandallow_topic_auto_creationconfigurable per client - Updated version from 1.27.2 to 1.28.0
- Added changelog entry documenting the new configuration options
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| mix.exs | Version bump to 1.28.0 |
| lib/kaffe/config/producer.ex | Made producer config options configurable with defaults |
| lib/kaffe/config/consumer.ex | Made consumer config options configurable with defaults |
| CHANGELOG.md | Added entry for 1.28.0 release documenting new configuration options |
| # 1.28.0 | ||
|
|
||
| * Allow `auto_start_producers` and `allow_topic_auto_creation` to be configurable for brod clients. If configuration of either of these values is desired, update your producer or consumer configs. | ||
|
|
Copilot
AI
Aug 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changelog entry should provide more specific guidance on how to configure these options. Consider adding examples of the configuration syntax or referencing documentation that explains the configuration format.
| Example configuration: | |
| ```elixir | |
| config :my_app, :brod, | |
| clients: [ | |
| my_client: [ | |
| auto_start_producers: false, | |
| allow_topic_auto_creation: true | |
| ] | |
| ] |
For more details, see the brod client configuration documentation.
|
Resolves #22 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for knocking out that issue! The code makes sense to me, and keeps the old defaults.
| @@ -1,3 +1,7 @@ | |||
| # 1.28.0 | |||
|
|
|||
| * Allow `auto_start_producers` and `allow_topic_auto_creation` to be configurable for brod clients. If configuration of either of these values is desired, update your producer or consumer configs. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Do you think it's worth telling what the default is if they're not specified? Maybe it's clear enough for someone to just look at the code 🤔
auto_start_producersandallow_topic_auto_creationare no longer hard coded, and can be configured per client (producer or consumer).This also bumps the version to 1.28.0
Resolves #151