Skip to content

Conversation

@TylerWitt
Copy link
Contributor

auto_start_producers and allow_topic_auto_creation are no longer hard coded, and can be configured per client (producer or consumer).

This also bumps the version to 1.28.0

Resolves #151

auto_start_producers and allow_topic_auto_creation are no longer hard coded, and can be configured per client (producer or consumer).
Copilot AI review requested due to automatic review settings August 4, 2025 21:25
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR allows configuration of auto_start_producers and allow_topic_auto_creation options for brod clients instead of having them hard-coded, and bumps the library version to 1.28.0.

  • Made auto_start_producers and allow_topic_auto_creation configurable per client
  • Updated version from 1.27.2 to 1.28.0
  • Added changelog entry documenting the new configuration options

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
mix.exs Version bump to 1.28.0
lib/kaffe/config/producer.ex Made producer config options configurable with defaults
lib/kaffe/config/consumer.ex Made consumer config options configurable with defaults
CHANGELOG.md Added entry for 1.28.0 release documenting new configuration options

# 1.28.0

* Allow `auto_start_producers` and `allow_topic_auto_creation` to be configurable for brod clients. If configuration of either of these values is desired, update your producer or consumer configs.

Copy link

Copilot AI Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog entry should provide more specific guidance on how to configure these options. Consider adding examples of the configuration syntax or referencing documentation that explains the configuration format.

Suggested change
Example configuration:
```elixir
config :my_app, :brod,
clients: [
my_client: [
auto_start_producers: false,
allow_topic_auto_creation: true
]
]

For more details, see the brod client configuration documentation.

Copilot uses AI. Check for mistakes.
@TylerWitt TylerWitt requested a review from a team August 4, 2025 21:26
@TylerWitt
Copy link
Contributor Author

TylerWitt commented Aug 4, 2025

Resolves #22

Copy link
Contributor

@fatcatt316 fatcatt316 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for knocking out that issue! The code makes sense to me, and keeps the old defaults.

@@ -1,3 +1,7 @@
# 1.28.0

* Allow `auto_start_producers` and `allow_topic_auto_creation` to be configurable for brod clients. If configuration of either of these values is desired, update your producer or consumer configs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Do you think it's worth telling what the default is if they're not specified? Maybe it's clear enough for someone to just look at the code 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Not possible to set auto_start_producers and allow_topic_auto_creation

3 participants