refactor(ReactExperienceAgentHook): update hooks' priority#30
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates hook ordering so the React strategy “experience” injection runs earlier in the REACT agent lifecycle (before the Fast/Quick Intent hook), ensuring downstream hooks see the injected behavior guidance.
Changes:
- Introduced
HookPriorityConstants.REACT_EXPERIENCE_HOOK = 20forbeforeAgentordering. - Updated
ReactExperienceAgentHookto implementPrioritizedand return the new priority viagetOrder(). - Expanded Javadoc to document intended ordering.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
assistant-agent-extensions/src/main/java/com/alibaba/assistant/agent/extension/experience/hook/ReactExperienceAgentHook.java |
Makes the hook prioritized and documents its intended execution order. |
assistant-agent-common/src/main/java/com/alibaba/assistant/agent/common/constant/HookPriorityConstants.java |
Adds a new priority constant for React experience injection in beforeAgent. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new priority constant for the React Experience Hook and updates the
ReactExperienceAgentHookclass to ensure it executes before the Quick Intent Hook. This change helps guarantee that React strategy experience is injected early in the agent lifecycle, influencing all subsequent hooks.Hook priority management:
REACT_EXPERIENCE_HOOK(value 20) toHookPriorityConstants, with documentation specifying its purpose and execution order in thebeforeAgentphase.ReactExperienceAgentHookto implement thePrioritizedinterface and overridegetOrder()to return the new priority constant, ensuring it runs before the Quick Intent Hook (priority 50). [1] [2]Imports and documentation:
HookPriorityConstantsandPrioritizedinReactExperienceAgentHook.java.ReactExperienceAgentHookto clarify the hook's priority and execution order.