Skip to content

fix(ReactExperienceAgentHook): update react experience limit #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
canfuu merged 1 commit into from
Mar 2, 2026
Merged

fix(ReactExperienceAgentHook): update react experience limit #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../java/com/alibaba/assistant/agent/extension/experience/hook/ReactExperienceAgentHook.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ public CompletableFuture<Map<String, Object>> beforeAgent(OverAllState state, Ru

// 查询React经验
ExperienceQuery query = new ExperienceQuery(ExperienceType.REACT);
query.setLimit(Math.min(properties.getMaxItemsPerQuery(), 3));
query.setLimit(Math.min(properties.getMaxItemsPerQuery(), 30));
// 关键修复：设置查询文本，用于向量搜索
Comment on lines 97 to 99
Copy link

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Raising the REACT query cap from 3 to 30 can significantly increase both (1) the amount of content injected into the conversation (buildReactStrategyContent only truncates per item, not total), and (2) the size of the INFO log line that serializes the full experiences list. Consider adding a total-size guard (e.g., stop appending after a max total chars/tokens) and/or reducing/truncating the INFO logging when higher limits are enabled via config.

Copilot uses AI. Check for mistakes.
if (StringUtils.hasText(userInput)) {
query.setText(userInput);
Expand Down