Add queryParams method to ProxyExchange #2833
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍🏻 I would love to see this |
spencergibb
requested changes
Mar 8, 2024
| public String path() { | ||
| return (String) this.webRequest.getAttribute(HandlerMapping.PATH_WITHIN_HANDLER_MAPPING_ATTRIBUTE, | ||
| WebRequest.SCOPE_REQUEST); | ||
| return exchange.getRequest().getPath().pathWithinApplication().value(); |
There was a problem hiding this comment.
There's no exchange in spring mvc, this doesn't even compile
There was a problem hiding this comment.
There was at the time I opened this MR.
There was a problem hiding this comment.
Server Web exchange is from spring webflux
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2129
I'm not sure if another method for exposing the original request's cookies is necessary. Otherwise users have to use reflection to read them.
Should probably also be cherry-picked into 3.1.xx.