Refactor header appending logic for better readability #3676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR refactors the logic for adding headers in the appendXForwarded and appendForwarded methods. Signed-off-by: Hyeon Sung <[email protected]>
…d and appendForwarded methods This PR refactors the logic for adding headers in the appendXForwarded and appendForwarded methods. Signed-off-by: Hyeon Sung <[email protected]>
add import Signed-off-by: Hyeon Sung <[email protected]>
ryanjbaxter
requested changes
Mar 11, 2025
| String host = headers.getFirst("x-forwarded-host"); | ||
| if (host == null) { | ||
| return; | ||
| appendXForwardedHeader("x-forwarded-host", () -> uri.getHost()); |
There was a problem hiding this comment.
Why are you using a Supplier?
| forwarded = ""; | ||
| String forwarded = headers.getFirst("forwarded"); | ||
| StringBuilder builder = new StringBuilder(); | ||
| if (StringUtils.hasText(forwarded)) { |
There was a problem hiding this comment.
I would maintain the null check so that the same headers are added for the proxied request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the logic for adding headers in the
appendXForwardedandappendForwardedmethods.Additionally
upon reviewing both the original and refactored code, I noticed that in
appendXForwarded, the result ofheaders.getFirst()is only checked for null.Wouldn't it be better to use StringUtils.hasText() instead, to ensure not only that the value is non-null but also that it contains text? What do you think about this approach?