Skip to content

Bypass PR triage for spring-petclinic org members#543

Merged
arey merged 2 commits into
mainfrom
feature/pr-workflows
May 17, 2026
Merged

Bypass PR triage for spring-petclinic org members#543
arey merged 2 commits into
mainfrom
feature/pr-workflows

Conversation

@arey

@arey arey commented May 17, 2026

Copy link
Copy Markdown
Member

Summary

This PR adds automated pull request triage to reduce invalid or low-signal submissions on the upstream project.

It introduces:

  • a PR template to require basic contribution context
  • a CONTRIBUTING section that clarifies what kinds of PRs are in scope
  • a single triage workflow that:
    • skips checks for spring-petclinic organization members
    • closes out-of-scope practice, test, or course-related PRs
    • flags incomplete PR descriptions with needs-information
    • auto-closes incomplete PRs after 7 days of inactivity

Why

This repository is widely used for courses, demos, and experimentation, which generates a significant number of PRs that are not intended for the upstream project.

The goal is to reduce maintainer noise while preserving a clear path for valid community contributions.

Implementation details

  • Merged PR triage logic into a single workflow to avoid parallel runs and duplicate comments
  • Added an org-member bypass using ORG_READ_PAT so both public and private spring-petclinic members are exempt from automated triage
  • Limited non-project pattern detection to PR title and branch name to avoid false positives from the PR template body
  • Kept all write operations on the default GITHUB_TOKEN so labels, comments, and closures still come from GitHub Actions

Validation

  • YAML syntax validated locally
  • Workflow logic reviewed for event handling and control flow
  • ORG_READ_PAT support added for private org membership checks

Notes

ORG_READ_PAT must be configured as an Actions secret and must belong to a spring-petclinic organization member with permission to read organization membership.

arey added 2 commits May 17, 2026 20:18
Use ORG_READ_PAT to check spring-petclinic organization membership
before applying PR triage rules.

This allows both public and private org members to bypass the
non-project PR detection and template completeness checks, while
keeping comments, labels, and PR closure actions on GITHUB_TOKEN.
@arey arey force-pushed the feature/pr-workflows branch from 44fc235 to 8a1978b Compare May 17, 2026 18:19
@sonarqubecloud

Copy link
Copy Markdown

@arey arey merged commit 305a1f1 into main May 17, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant