GH-5832: Fix StructuredOutputValidationAdvisor to validate all results#5833
Closed
ArpanC6 wants to merge 2 commits intospring-projects:mainfrom
Closed
GH-5832: Fix StructuredOutputValidationAdvisor to validate all results#5833ArpanC6 wants to merge 2 commits intospring-projects:mainfrom
ArpanC6 wants to merge 2 commits intospring-projects:mainfrom
Conversation
…first one Signed-off-by: Arpan Chakraborty <chakrabortyarpan151@gmail.com>
Author
|
I've submitted a pull request for this issue #5833 |
…xSseServerTransportProvider Signed-off-by: Arpan Chakraborty <chakrabortyarpan151@gmail.com>
Author
|
Thank you for the heads up. I wasn't aware of PR #5846. Closing this in favor of that PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes
validateOutputSchema()to validate all results in aChatResponseinstead of only the first one.
Why
ChatResponse.getResult()returns only the first result. When multiple resultsexist, the remaining ones were silently skipped invalid JSON could pass
validation undetected.
Addresses the TODO comment on line 191:
// TODO: should we consider validation for multiple results?How
Replaced
getResult()withgetResults()and added a loop to validate eachresult individually. Returns the first validation failure encountered.
Closes #5832