GH-5889: Fix CsvSource parsing in TikaDocumentReaderTests#5890
Open
rodolfo-mendes wants to merge 1 commit intospring-projects:mainfrom
Open
GH-5889: Fix CsvSource parsing in TikaDocumentReaderTests#5890rodolfo-mendes wants to merge 1 commit intospring-projects:mainfrom
rodolfo-mendes wants to merge 1 commit intospring-projects:mainfrom
Conversation
…DocumentReaderTests`, so `contentSnipped` values containing commas are not broke. Closes spring-projects#5889 Signed-off-by: Rodolfo Mendes <rodolfo.m.s.mendes@gmail.com>
rodolfo-mendes
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
TikaDocumentReaderTestsparameterized test data that included commas incontentSnippedvalues.Previously, rows that relied on the default
@CsvSourceseparator could misparse snippet values containing commas, causing the test to assert against truncated content.This change updates the parameterized test input to use a non-comma delimiter so the full snippet text is preserved.
Affected file:
document-readers/tika-reader/src/test/java/org/springframework/ai/reader/tika/TikaDocumentReaderTests.javaCloses #5889