refactor: optimize internal string building#5914
Open
KoreaNirsa wants to merge 1 commit intospring-projects:mainfrom
Open
refactor: optimize internal string building#5914KoreaNirsa wants to merge 1 commit intospring-projects:mainfrom
KoreaNirsa wants to merge 1 commit intospring-projects:mainfrom
Conversation
Signed-off-by: KoreaNirsa <islandtim@naver.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR optimizes a couple of internal string-building paths without changing existing behavior
String.format("%02x", b)usage inJdkSha256HexIdGeneratorwith Java 17HexFormatreduceinMiniMaxApi#getTextContentwithCollectors.joining()Performance benefit
String.format("%02x", b)is relatively expensive for byte-by-byte hex encoding because it goes through formatter parsing and formatting machinery on every byte.HexFormatis purpose-built for byte-to-hex conversion and avoids that repeated formatting overheadSimilarly, string concatenation inside
reducecreates intermediateStringinstances as the stream is accumulatedCollectors.joining()uses a mutable accumulation strategy internally, which avoids repeated intermediate concatenations and is the idiomatic collector for joining stream elements