Check user code expiry and invalidity #1997
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes spring-projectsgh-1894 and spring-projectsgh-1977 Signed-off-by: Antoine Lauzon <[email protected]>
antoinelauzon-bell
force-pushed
the
user-code-validation
branch
from
27af228 to
31d5ac3
Compare
spring-projects-issues
added
the
status: waiting-for-triage
|
Would it not be better to just check |
| if (this.logger.isTraceEnabled()) { | ||
| this.logger.trace("User code is expired"); | ||
| } | ||
| throw new OAuth2AuthenticationException(OAuth2ErrorCodes.INVALID_GRANT); |
There was a problem hiding this comment.
Is it worth providing more context on the error..
Suggested change
| throw new OAuth2AuthenticationException(OAuth2ErrorCodes.INVALID_GRANT); | |
| OAuth2Error error = new OAuth2Error(OAuth2ErrorCodes.INVALID_GRANT, "User code is expired.", null); | |
| throw new OAuth2AuthenticationException(error); |
| if (this.logger.isTraceEnabled()) { | ||
| this.logger.trace("User code is invalided"); | ||
| } | ||
| throw new OAuth2AuthenticationException(OAuth2ErrorCodes.INVALID_GRANT); |
There was a problem hiding this comment.
Is it worth providing more context on the error..
Suggested change
| throw new OAuth2AuthenticationException(OAuth2ErrorCodes.INVALID_GRANT); | |
| OAuth2Error error = new OAuth2Error(OAuth2ErrorCodes.INVALID_GRANT, "User code is invalidated.", null); | |
| throw new OAuth2AuthenticationException(error); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It ensures that a user code is neither expired nor invalidated during the verification step. See gh-1894 and gh-1977 for more details.
Notes:
invalidat_grantappears to be the expected error code (see RFC 6749, Section 5.2). It might be useful to distinguish these exceptions though (e.g. by using subclasses of OAuth2AuthenticationException).