GH-5356: Optimize findRunningJobExecutions to use batch query#5357
Open
Wordbe wants to merge 1 commit intospring-projects:mainfrom
Open
GH-5356: Optimize findRunningJobExecutions to use batch query#5357Wordbe wants to merge 1 commit intospring-projects:mainfrom
Wordbe wants to merge 1 commit intospring-projects:mainfrom
Conversation
…h query Replace N+1 MongoDB queries with a single batch query using the $in operator in MongoJobExecutionDao.findRunningJobExecutions(). Signed-off-by: Wordbe <seonghojin3@gmail.com>
quaff
reviewed
Mar 25, 2026
| if (jobInstances.isEmpty()) { | ||
| return Collections.emptySet(); | ||
| } | ||
| Map<Long, JobInstance> jobInstanceMap = new HashMap<>(); |
Contributor
There was a problem hiding this comment.
You can use streams here.
Map<Long, JobInstance> jobInstanceMap = jobInstances.stream().collect(Collectors.toMap(JobInstance::getId, Function.identity()));
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MongoJobExecutionDao.findRunningJobExecutions()issues N+1 MongoDB queries, where N is the total number of job instances for a given job name.This change replaces individual per-instance queries with a single batch query using the
$inoperator.Before: 1 query (load all instances) + N queries (one per instance) = 1+N queries
After: 1 query (load all instances) + 1 batch query (
$in) = 2 queriesChanges
Map<Long, JobInstance>from loaded instances for O(1) lookup$in(jobInstanceMap.keySet())to find all running executions in a single queryCloses #5356
mainand squash commits