Add info about new Data Initialization modules#49839
Add info about new Data Initialization modules#49839ppapaj wants to merge 3 commits intospring-projects:mainfrom
Conversation
Signed-off-by: Piotr Papaj <4591951+ppapaj@users.noreply.github.com>
4c75bef to
a8b2c8f
Compare
|
Thanks for the proposal. Rather than adding a note, I think it would be better to update the documentation that talks about the Flyway and Liquibase dependencies: |
Signed-off-by: Piotr Papaj <4591951+ppapaj@users.noreply.github.com>
|
I updated the docs accordingly, you can take a look |
wilkinsona
left a comment
There was a problem hiding this comment.
Thanks for the updates. I've left a couple of further comments for your consideration.
| === Execute Liquibase Database Migrations on Startup | ||
|
|
||
| To automatically run Liquibase database migrations on startup, add the `org.liquibase:liquibase-core` to your classpath. | ||
| To automatically run Liquibase database migrations on startup, add the `org.liquibase:liquibase-core` and `spring-boot-starter-liquibase` to your classpath. |
There was a problem hiding this comment.
There's no need for both dependencies as liquibase-core is a dependency of spring-boot-starter-liquibase.
There was a problem hiding this comment.
You're absolutely right. Fixed along with the reference to the library in the note below.
| To automatically run Flyway database migrations on startup, add the appropriate Flyway module to your classpath along with `spring-boot-starter-flyway` module. | ||
| In-memory and file-based databases are supported by `org.flywaydb:flyway-core`. | ||
| Otherwise, a database-specific module is required. | ||
| For example, use `org.flywaydb:flyway-database-postgresql` with PostgreSQL and `org.flywaydb:flyway-mysql` with MySQL. |
There was a problem hiding this comment.
This isn't quite right. We should instruct users to add spring-boot-starter-flyway. That's all they need for in-memory and file-based DBs.
wilkinsona
left a comment
There was a problem hiding this comment.
I've left a couple of comments for your consideration, @ppapaj.
Signed-off-by: Piotr Papaj <4591951+ppapaj@users.noreply.github.com>
This change is a minor fix in the documentation.
I found the current phrasing a bit misleading as of Spring Boot 4.0 there's a new dependency required for automated Flyway and Liquibase migrations. If you have any suggestions about the phrasing - I'll be more than happy to adjust.