Honor HttpMethod for reactive additional endpoint paths#49864
Open
dlwldnjs1009 wants to merge 2 commits intospring-projects:mainfrom
Open
Honor HttpMethod for reactive additional endpoint paths#49864dlwldnjs1009 wants to merge 2 commits intospring-projects:mainfrom
dlwldnjs1009 wants to merge 2 commits intospring-projects:mainfrom
Conversation
Reactive EndpointRequest.toAdditionalPaths(...).withHttpMethod(...) stores the configured HttpMethod but does not pass it to the underlying matcher. As a result, additional endpoint paths match regardless of the configured request method. Update the reactive matcher to pass the configured method through and add a regression test to verify that only matching methods are accepted. Signed-off-by: LeeJiWon <dlwldnjs1009@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
Signed-off-by: LeeJiWon <dlwldnjs1009@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reactive
EndpointRequest.toAdditionalPaths(...).withHttpMethod(...)stores theconfigured
HttpMethodbut does not pass it to the underlying matcher. As aresult, additional endpoint paths match regardless of the configured request
method.
The servlet variant passes the configured method through when creating the
matcher for additional paths. This change makes the reactive variant do the
same and adds a regression test to verify that only matching methods are
accepted.
Testing:
JAVA_HOME=/Users/jiwon/Library/Java/JavaVirtualMachines/openjdk-25.0.2/Contents/Home ./gradlew :module:spring-boot-security:test --tests 'org.springframework.boot.security.autoconfigure.actuate.web.reactive.EndpointRequestTests'