Allow whitespace in JPQL and EQL JDBC escape literals.#4294
Open
jewoodev wants to merge 1 commit into
Open
Conversation
JPQL and EQL lex JDBC date, time, and timestamp escape literals as single tokens. This required the marker to be directly followed by the quoted literal and rejected forms such as `{d '2012-01-03'}`.
Allow optional whitespace after the marker while preserving the existing no-whitespace forms, and add renderer coverage for JPQL and EQL.
Signed-off-by: jewoodev <jewoos15@naver.com>
jewoodev
changed the title
spring-projects-issues
added
the
status: waiting-for-triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JPQL and EQL currently tokenize JDBC date, time, and timestamp escape literals only when the marker is directly followed by the quoted literal. That rejects common JDBC-style forms such as
{d '2012-01-03'}during lexing.This change allows optional whitespace after the JDBC escape marker in the JPQL and EQL lexer rules and adds renderer coverage for date, time, and timestamp literals. Existing no-whitespace forms remain covered by the shared renderer TCK.