Skip to content

Polishing. #4977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Polishing. #4977

wants to merge 1 commit into from

Conversation

mp911de
Copy link
Member

@mp911de mp911de commented May 19, 2025

Fix contract annotations, add missing Override annotations, make fields final where possible.

@mp911de
Polishing.
a1887d5 
Fix contract annotations, add missing Override annotations, make fields final where possible.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 19, 2025
odrotbohm
odrotbohm reviewed May 19, 2025
View reviewed changes
Copy link
Member

@odrotbohm odrotbohm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

christophstrobl pushed a commit that referenced this pull request May 19, 2025
@mp911de @christophstrobl
Polishing.
9a40b7e 
Fix contract annotations, add missing Override annotations, make fields final where possible.

See: #4874
Original Pull Request: #4977
@christophstrobl
Copy link
Member

Thanks @mp911de - merged to main development line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odrotbohm odrotbohm odrotbohm left review comments

@christophstrobl christophstrobl Awaiting requested review from christophstrobl

Assignees

@christophstrobl christophstrobl

Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mp911de @christophstrobl @odrotbohm @spring-projects-issues