Make multiple slash sanitization optional in web util #34242
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
Closes spring-projectsgh-34076 Signed-off-by: vishnugt <[email protected]>
vishnugt
commented
Jan 11, 2025
| * <ul> | ||
| * <li>replace all "//" by "/"</li> | ||
| * </ul> | ||
| */ | ||
| private static String getSanitizedPath(final String path) { | ||
| private String getSanitizedPath(final String path) { |
There was a problem hiding this comment.
This was a private static method that had 2 usages in the class, made it non-static to use the flag.
I can abstract the actual removing slash logic into a static method and have a non-static wrapper if you think that makes sense.
vishnugt
commented
Jan 11, 2025
| @@ -911,7 +931,7 @@ public void append(String... pathSegments) { | |||
| } | |||
|
|
|||
| @Override | |||
| public @Nullable PathComponent build() { | |||
| public @Nullable PathComponent build(boolean sanitizePath) { | |||
There was a problem hiding this comment.
Here we don't use the sanitizePath flag, but I couldn't come up with any other approach that requires minimal changes while addressing the sanitizePath flag, especially considering that two of the three implementations make use of it. If you have a better solution, I’d be happy to implement it.
|
Thanks for contributing to Spring Framework. |
bclozel
added
in: web
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make multiple slash sanitization optional in UriComponentsBuilder and UrlPathHelper
No breaking changes introduced; users can continue using the default behavior without modification.
Optional multi-slash sanitization is added to align with section 3.3 of RFC 3986, which permits empty path segments.
Closes gh-34076