Prepare for client interceptors #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit moves the `ApplicationContextBeanLookupUtils` into the 'internal' package and opens up its method to public visibility so that it can be shared amongst framework components. See spring-projects#52 Signed-off-by: Chris Bono <[email protected]>
This commit renames the GrpcChannelConfigurer to GrpcChannelBuilderCustomizer to more accurately represent its purpose and for consistency with the server-side terminology. Additionally, a new `What's new?` doc is added to list breaking changes between versions. See spring-projects#52 Signed-off-by: Chris Bono <[email protected]>
This commit moves the client properties customizer from an inner class to its own top-level class to make it easier to test and for readability. Signed-off-by: Chris Bono <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prepares for adding client interceptors as follows.
Note
The commits are separate by design - please do not squash during merge
Commit 1: Move bean lookup utils into common package
This commit moves the
ApplicationContextBeanLookupUtilsinto the'internal' package and opens up its method to public visibility so
that it can be shared amongst framework components.
Commit 2: Rename client configurer to customizer
This commit renames the
GrpcChannelConfigurertoGrpcChannelBuilderCustomizerto more accurately represent its purpose and for consistency with the
server-side terminology.
Additionally, a new
What's new?doc is added to list breaking changes betweenversions.
Commit 3: Move client properties customizer to upper level
This commit moves the client properties customizer from an inner class
to its own top-level class to make it easier to test and for readability.
See #52