Fix pet update functionality - Fixed issue where editing a pet's type… #1765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… or name wasn't persisting - Updated processUpdateForm to modify existing pet instead of adding new one - Added proper handling of existing pet update Fixes spring-projects#1752
|
@VishantOwO Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@VishantOwO Thank you for signing the Contributor License Agreement! |
src/main/java/org/springframework/samples/petclinic/owner/PetController.java
Show resolved
Hide resolved
andrzejsydor
reviewed
Jan 2, 2025
src/main/java/org/springframework/samples/petclinic/owner/PetController.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Pet Update Functionality
Description
Fixed an issue where editing a pet's type or name wasn't persisting in the database, even though a success message was shown.
Changes made
processUpdateFormto update existing pet properties instead of usingaddPetNote: I'm new to contributing and haven't added tests yet. I'd be happy to add them if required.