-
Notifications
You must be signed in to change notification settings - Fork 29k
Add API to filter pets by type and name with lightweight response end… #2318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shrutisharma-sh
wants to merge
1
commit into
spring-projects:main
Choose a base branch
from
shrutisharma-sh:feature/petfilter-api
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+94
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
19 changes: 19 additions & 0 deletions
19
src/main/java/org/springframework/samples/petclinic/owner/PetResponse.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| package org.springframework.samples.petclinic.owner; | ||
|
|
||
| public class PetResponse { | ||
| private String name; | ||
| private String type; | ||
|
|
||
| public PetResponse(String name, String type) { | ||
| this.name = name; | ||
| this.type = type; | ||
| } | ||
|
|
||
| public String getName() { | ||
| return name; | ||
| } | ||
|
|
||
| public String getType() { | ||
| return type; | ||
| } | ||
| } |
75 changes: 75 additions & 0 deletions
75
src/main/java/org/springframework/samples/petclinic/owner/PetRestController.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| package org.springframework.samples.petclinic.owner; | ||
|
|
||
| import org.springframework.web.bind.annotation.GetMapping; | ||
| import org.springframework.web.bind.annotation.RequestMapping; | ||
| import org.springframework.web.bind.annotation.RequestParam; | ||
| import org.springframework.web.bind.annotation.RestController; | ||
|
|
||
| import java.util.ArrayList; | ||
| import java.util.List; | ||
|
|
||
| @RestController | ||
| @RequestMapping("/api") | ||
|
|
||
| public class PetRestController { | ||
|
|
||
| private final OwnerRepository ownerRepository; | ||
|
|
||
| public PetRestController(OwnerRepository ownerRepository) { | ||
| this.ownerRepository = ownerRepository; | ||
| } | ||
|
|
||
| @GetMapping("/pets") | ||
| public List<Pet> getPets( | ||
| @RequestParam(required = false) String type, | ||
| @RequestParam(required = false) String name) { | ||
|
|
||
| List<Pet> result = new ArrayList<>(); | ||
|
|
||
|
|
||
| List<Owner> owners = ownerRepository.findAll(); | ||
|
|
||
| for (Owner owner : owners) { | ||
| for (Pet pet : owner.getPets()) { | ||
|
|
||
| boolean matchesType = (type == null || pet.getType().getName().equalsIgnoreCase(type)); | ||
| boolean matchesName = (name == null || pet.getName().equalsIgnoreCase(name)); | ||
|
|
||
| if (matchesType && matchesName) { | ||
| result.add(pet); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| return result; | ||
| } | ||
|
|
||
| // Returns only pet name and type with optional filtering by type and name | ||
| @GetMapping("/pets/names") | ||
| public List<PetResponse> getPetNames( | ||
| @RequestParam(required = false) String type, | ||
| @RequestParam(required = false) String name) { | ||
|
|
||
| List<PetResponse> result = new ArrayList<>(); | ||
|
|
||
| List<Owner> owners = ownerRepository.findAll(); | ||
|
|
||
| for (Owner owner : owners) { | ||
| for (Pet pet : owner.getPets()) { | ||
|
|
||
| boolean matchesType = (type == null || pet.getType().getName().equalsIgnoreCase(type)); | ||
| boolean matchesName = (name == null || pet.getName().equalsIgnoreCase(name)); | ||
|
|
||
| if (matchesType && matchesName) { | ||
| result.add(new PetResponse( | ||
| pet.getName(), | ||
| pet.getType().getName() | ||
| )); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| return result; | ||
| } | ||
| } | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use a service layer so that logic will be in the service layer rather than in the controller itself.