Fix #2337: Enforce future dates for Pet Visits#2342
Open
ahmedAlweimine wants to merge 2 commits intospring-projects:mainfrom
Open
Fix #2337: Enforce future dates for Pet Visits#2342ahmedAlweimine wants to merge 2 commits intospring-projects:mainfrom
ahmedAlweimine wants to merge 2 commits intospring-projects:mainfrom
Conversation
Signed-off-by: AhmedBabaAlweimine <ahmedouldbaba4@gmail.com>
Signed-off-by: AhmedBabaAlweimine <ahmedouldbaba4@gmail.com>
Author
|
Thanks for the review, @marcosgdz03 , This was a great first experience contributing to the project. I'm looking forward to the merge and hopefully tackling more issues in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Visit.java: Updated constructor to default to tomorrow's date and added @future constraint.
VisitController.java: Added manual backend check to reject dates not in the future.
HTML: Enhanced inputField.html fragment to support min attribute and updated createOrUpdateVisitForm.html to enforce it.
Tests: Comprehensive unit and integration tests added to verify validation logic and error messages.
VisitControllerTests.java: Added both positive (success) and negative (error) test cases for visit dates.
ValidatorTests.java: Added verification to ensure the @future constraint triggers correctly.