Skip to content

Add ServerWebExchange parameter to AuthorizationRequestCustomizer #16320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add ServerWebExchange parameter to AuthorizationRequestCustomizer #16320

wants to merge 1 commit into from

Conversation

kse-music
Copy link
Contributor

Closes gh-16306

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 20, 2024
@sjohnr sjohnr self-assigned this Dec 20, 2024
@sjohnr sjohnr added type: enhancement A general enhancement in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) labels Dec 20, 2024
@sjohnr
Copy link
Member

sjohnr commented Mar 20, 2025

@kse-music thanks for the PR. I apologize for the delay in reviewing. However, I don't feel confident that we want to pursue simply introducing a BiConsumer here. This isn't generally the best way to expose a new parameter for customization, and I don't see any precedent for it in Spring Security. For that reason, I'm going to close this PR for now and ask that you weigh in on the issue with your use case and ideas so we can find a path forward through discussion before moving to the PR stage. Thanks for understanding.

@sjohnr sjohnr closed this Mar 20, 2025
@sjohnr sjohnr added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sjohnr sjohnr

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: declined A suggestion or change that we don't feel we should currently apply type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pass Http Request to OAuth2AuthorizationRequestResolver#authorizationRequestCustomizer
3 participants
@kse-music @sjohnr @spring-projects-issues