CMakeLists: add PPC support, unbreak build on Darwin#27
Open
barracuda156 wants to merge 1 commit intospringer13:masterfrom
Open
CMakeLists: add PPC support, unbreak build on Darwin#27barracuda156 wants to merge 1 commit intospringer13:masterfrom
barracuda156 wants to merge 1 commit intospringer13:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-march=is unsupported on PPC, but it is used in a fallback, therefore breaking the build on macOS PPC (and likely Big Endian FreeBSD, Linux etc).I have used
-DHPTT_ARCH_IBMfor Apple here, since the code appears Altivec-compatible and builds fine. However once/if insns from ISA newer than 2.03 are added, non-VSX code should be retained separately for cases where those are unsupported, and then-DHPTT_ARCH_PPCwill be needed.P. S. I suspect that a separate case may be needed for Apple Clang on Intel, since it does not support OpenMP (at least most of its versions). But keeping this PR to PPC.