Simplify rating description, remove overwhelming information. - #905
Open
raquel-roldo wants to merge 1 commit into
Open
Simplify rating description, remove overwhelming information.#905raquel-roldo wants to merge 1 commit into
raquel-roldo wants to merge 1 commit into
Conversation
morgaan
reviewed
Aug 4, 2026
morgaan
left a comment
morgaan
left a comment
Contributor
There was a problem hiding this comment.
Thank you for tackling this @raquel-roldo 🫶
I left a comment for which I'd be interested to get @fred-warburton view on.
| <h{{headingLevel}} class="c-customer-satisfaction-input__heading">How was your experience today?</h{{headingLevel}}> | ||
| <fieldset class="c-customer-satisfaction-input__fieldset c-customer-satisfaction-input__field" id="csat-radios{{#if id}}-{{id}}{{/if}}" name="csat-radios" invalid="" aria-describedby="csat-radios-error{{#if id}}-{{id}}{{/if}}" required="" autocomplete="off"> | ||
| <legend class="c-customer-satisfaction-input__visually-hidden">Rating. A scale of 5 feelings conveyed using images that range from awful to great. The feelings represent how you feel about your experience today.</legend> | ||
| <legend class="c-customer-satisfaction-input__visually-hidden">Select one rating.</legend> |
Contributor
There was a problem hiding this comment.
I do wonder if we cannot even simplify further down to just “Rating” TBH.
Reasoning:
- Some screen readers (e.g. Voice over) will read the legend out for every field what may be cumbersome and redundant to hear the "Select one" prefix each time.
- The user is presented with radio buttons what may implicitly suggests it is a single-choice option, and therefore make the “Select one” redundant.
That being said, I had seen examples by accessibility specialists including the action verb (e.g. select, choose...) in the legend 🤷.
It may be interesting to get @fred-warburton's view on this.
Author
There was a problem hiding this comment.
Thanks @morgaan. That's a good point, I'd go with just "Rating", specially considering the possibility of it being read multiple times by some screen readers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! Hopefully this is how it's done, let me know what you think.