Remove battery device_class from Fox SOH sensor to prevent HA low-battery false alerts

[Copilot]

Fox battery SOH is published as a health factor (0.0–1.0), but it was tagged with device_class: battery, which Home Assistant Maintenance interprets as remaining charge %. This caused persistent false low-battery warnings (e.g., 1.0 interpreted as 1%).

• Sensor metadata correction

  • Updated Fox SOH sensor publishing to stop advertising device_class: battery.
  • Kept existing SOH semantics (state remains normalized fraction; unit_of_measurement: "*", state_class: "measurement", and icon unchanged).

• Test expectation alignment

  • Updated the Fox API SOH publishing test to assert device_class is absent for the SOH entity.

self.dashboard_item(
    entity_name_sensor + "_" + sn.lower() + "_battery_soh",
    state=soh_fraction,
    attributes={
        "friendly_name": f"Fox {sn} Battery State of Health",
        "unit_of_measurement": "*",
        "state_class": "measurement",
        "icon": "mdi:battery-heart",
    },
    app="fox",
)

• Fixes Fox Battery SOH sensor incorrectly uses device_class: battery, causing low battery alert on Home Assistant Maintenance dashboard #4485

[Copilot]

Pull request overview

This PR corrects the Home Assistant metadata for the Fox Battery State of Health (SOH) sensor so it is no longer misclassified as a “battery remaining charge” sensor, preventing false low-battery warnings in the HA Maintenance dashboard.

Changes:

• Removed device_class: battery from the Fox _battery_soh sensor attributes while keeping the SOH value as a normalized fraction (0.0–1.0) and preserving existing unit/state_class/icon metadata.
• Updated the Fox API publishing test to assert that device_class is not present on the SOH sensor.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
apps/predbat/fox.py	Stops publishing device_class: battery for the Fox battery SOH sensor to avoid HA interpreting SOH as remaining charge %.
apps/predbat/tests/test_fox_api.py	Aligns test expectations to require device_class be absent for the SOH entity attributes.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.