docs: report on the planning performance work - #4547
Merged
Conversation
Records the measured result (39.5s to 24.8s on the 20-scenario benchmark, plans unchanged), what the two PRs changed, and the four design assumptions that a benchmark overturned - the scratch reuse that turned out to be a no-op, the broadcast wake that cost most of the win, the thread cap that was right on fast hardware and wrong on slow, and an inherited baseline that did not survive re-measurement. Also records the defects found on the way, including the ABI version that let a stale binary load and segfault, and the five tests that could not have failed until they were mutation-checked. Lives under docs/superpowers/ with the plans and specs rather than in the MkDocs nav: it is an engineering record, not user documentation. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an engineering report documenting the planning-performance improvements that landed via PR #4540 and #4546, capturing benchmark methodology, measured results, key design changes, and notable defects/assumptions uncovered during the work.
Changes:
- Introduces a detailed performance report (benchmark results, methodology, and analysis) for the batching and kernel thread-pool work.
- Records measurement-driven conclusions (what helped, what didn’t, and why) plus defects found and how tests were validated.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation only — no code changes.
The report on the planning performance work was written while #4540 and #4546 were still open, and landed on the branch just after each was merged, so it missed both. This carries it in on its own.
It records, for the work now in
main:mainat the time, each side on its own Python and kernel, interleaved, best of three.__main__entry point, and a header that only libc++ provides transitively.Filed under
docs/superpowers/with the plans and specs rather than in the MkDocs nav, since it is an engineering record rather than user documentation.🤖 Generated with Claude Code