-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
Signed-off-by: tcar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for updating all of the contract addresses @tcar121293 🙏
a few changes requested:
- naming the duplicated
Dynamic Fee Handler
's differently in the Sepolia section - not sure if it's too late, but where possible, pls verify all new contracts that get deployed 🙇
- some of the contract addresses don't seem like actual deployed contracts, more like untouched EOAs. ive tried highlighting them all with a comment.
- the Amoy section contains all broken links to the OKLink block explorer. ive provided the amended hyperlinks if you could pls replace them 🙏
- small spelling corrections
thank you so much!!!
Signed-off-by: tcar <[email protected]>
I resolved most of the issues. Only thing that is left is the verification issues. We have a known issue with verifying contracts on cronos. I was also unable to verify percentage fee handler on some of the networks. and gmp handler on the b3-sepolia. I think we can close this docs PR, and handle the verification of the contracts later |
sgtm! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Description
For the reference, this are the new changes