Skip to content
This repository was archived by the owner on Mar 11, 2025. It is now read-only.

chore: update feeHandlers #159

Merged
merged 2 commits into from
Jul 9, 2024
Merged

chore: update feeHandlers #159

merged 2 commits into from
Jul 9, 2024

Conversation

tcar121293
Copy link
Contributor

Description

  • removed bison testnet
  • updated feeRouter and feeHandler addresses
  • updated gmp handler on b3-sepolia
  • updated resources

For the reference, this are the new changes

Copy link
Contributor

@haochizzle haochizzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for updating all of the contract addresses @tcar121293 🙏
a few changes requested:

  • naming the duplicated Dynamic Fee Handler's differently in the Sepolia section
  • not sure if it's too late, but where possible, pls verify all new contracts that get deployed 🙇
  • some of the contract addresses don't seem like actual deployed contracts, more like untouched EOAs. ive tried highlighting them all with a comment.
  • the Amoy section contains all broken links to the OKLink block explorer. ive provided the amended hyperlinks if you could pls replace them 🙏
  • small spelling corrections

thank you so much!!!

Signed-off-by: tcar <[email protected]>
@tcar121293
Copy link
Contributor Author

thanks for updating all of the contract addresses @tcar121293 🙏 a few changes requested:

  • naming the duplicated Dynamic Fee Handler's differently in the Sepolia section
  • not sure if it's too late, but where possible, pls verify all new contracts that get deployed 🙇
  • some of the contract addresses don't seem like actual deployed contracts, more like untouched EOAs. ive tried highlighting them all with a comment.
  • the Amoy section contains all broken links to the OKLink block explorer. ive provided the amended hyperlinks if you could pls replace them 🙏
  • small spelling corrections

thank you so much!!!

I resolved most of the issues. Only thing that is left is the verification issues. We have a known issue with verifying contracts on cronos. I was also unable to verify percentage fee handler on some of the networks. and gmp handler on the b3-sepolia. I think we can close this docs PR, and handle the verification of the contracts later

@MakMuftic MakMuftic requested a review from haochizzle July 8, 2024 16:02
@haochizzle
Copy link
Contributor

sgtm!

Copy link
Contributor

@haochizzle haochizzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@haochizzle haochizzle enabled auto-merge (squash) July 9, 2024 12:18
@haochizzle haochizzle merged commit 95e6591 into develop Jul 9, 2024
1 check passed
@haochizzle haochizzle deleted the tcar/replace-fee-handlers branch July 9, 2024 12:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants