PR: Don’t assume Python is called python in tests
#77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #77 +/- ##
=======================================
Coverage 92.20% 92.20%
=======================================
Files 12 12
Lines 577 577
=======================================
Hits 532 532
Misses 45 45 ☔ View full report in Codecov by Sentry. |
ccordoba12
reviewed
Sep 10, 2023
Member
ccordoba12
left a comment
ccordoba12
left a comment
There was a problem hiding this comment.
Thanks @musicinmybrain for your contribution!
ccordoba12
changed the title
python in tests
Member
|
@musicinmybrain, please check our linting workflow to report the error reported by it and make our tests pass. |
musicinmybrain
force-pushed
the
test-python-executable
branch
from
14fbbfb to
5278255
Compare
Use sys.executable instead.
musicinmybrain
force-pushed
the
test-python-executable
branch
from
5278255 to
97a70c9
Compare
ccordoba12
approved these changes
Sep 10, 2023
Member
ccordoba12
left a comment
ccordoba12
left a comment
There was a problem hiding this comment.
Looks good to me now, thanks @musicinmybrain!
Contributor
Author
|
Thanks for the quick review! |
dalthviz
changed the title
python in testspython in tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
sys.executableinstead.