PR: Add feature to prepend/append PYTHONPATH to sys.path #478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
7 tasks
mrclary
force-pushed
the
ppm-syspath
branch
5 times, most recently
from
a76e1d3 to
a7a55e2
Compare
jitseniesen
approved these changes
May 16, 2024
Member
jitseniesen
left a comment
jitseniesen
left a comment
There was a problem hiding this comment.
Looks good, just one suggestion (typo in comment) to prove that I did look at it 😄
mrclary
force-pushed
the
ppm-syspath
branch
2 times, most recently
from
203ae2b to
fdfc7a2
Compare
mrclary
force-pushed
the
ppm-syspath
branch
2 times, most recently
from
9a06514 to
1c911a0
Compare
ccordoba12
reviewed
May 30, 2024
Member
ccordoba12
left a comment
ccordoba12
left a comment
There was a problem hiding this comment.
This looks pretty good, thanks @mrclary! I only left a couple of suggestions and a comment for you.
mrclary
commented
May 30, 2024
mrclary
commented
May 30, 2024
mrclary
force-pushed
the
ppm-syspath
branch
2 times, most recently
from
de85db9 to
4a1ab57
Compare
mrclary
force-pushed
the
ppm-syspath
branch
from
0e7adfe to
33db307
Compare
mrclary
force-pushed
the
ppm-syspath
branch
2 times, most recently
from
3d563a3 to
7b1dff7
Compare
mrclary
force-pushed
the
ppm-syspath
branch
2 times, most recently
from
c25ae4b to
9babbc7
Compare
ccordoba12
reviewed
Feb 16, 2025
Member
ccordoba12
left a comment
ccordoba12
left a comment
There was a problem hiding this comment.
Last review, then this should be ready.
…ad of or behind sys.path
… be invoked by Spyder after startup.
…upon update. This obviates the need for sending the old user paths with the sig_pythonpath_updated signal. What happened to the '' (current working directory) entry in sys.path?
…er the kernels starts. This is removed prior to kernel startup to protect spyder-kernels from offending user modules, but should be put back after startup.
Co-authored-by: Jitse Niesen <[email protected]>
Co-authored-by: Carlos Cordoba <[email protected]>
Co-authored-by: Carlos Cordoba <[email protected]>
ccordoba12
approved these changes
Feb 18, 2025
Member
ccordoba12
left a comment
ccordoba12
left a comment
There was a problem hiding this comment.
Looks good to me now, thanks @mrclary!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update_syspathis now the new paths as list of strings (instead of dictionary) and whether to append/prepend the new paths tosys.path. Old paths are not needed. The originalsys.pathis stored at module import and used to construct newsys.pathwith new paths sent from Spyder, rather than removing old paths.set_spyder_pythonpath. Spyder now sends new paths after kernel startup.