PR: Add logic to handle traceback color configuration #521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalthviz
changed the title
Merged
1 task
dalthviz
commented
Nov 18, 2024
dalthviz
force-pushed
the
spyder_22965
branch
from
6939c42 to
753558a
Compare
dalthviz
force-pushed
the
spyder_22965
branch
from
753558a to
07b9ca3
Compare
dalthviz
changed the title
ccordoba12
reviewed
Nov 20, 2024
Member
ccordoba12
left a comment
ccordoba12
left a comment
There was a problem hiding this comment.
Thanks @dalthviz for this great improvement!
Co-authored-by: Carlos Cordoba <[email protected]>
dalthviz
force-pushed
the
spyder_22965
branch
from
98ef53a to
a2b5893
Compare
dalthviz
force-pushed
the
spyder_22965
branch
from
a2b5893 to
db71627
Compare
ccordoba12
reviewed
Nov 21, 2024
Member
ccordoba12
left a comment
ccordoba12
left a comment
There was a problem hiding this comment.
Last couple of comments @dalthviz, then this should be ready.
Co-authored-by: Carlos Cordoba <[email protected]>
ccordoba12
approved these changes
Nov 26, 2024
Member
ccordoba12
left a comment
ccordoba12
left a comment
There was a problem hiding this comment.
Looks good to me now, thanks @dalthviz!
Member
|
@meeseeksdev please backport to 3.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/spyder-kernels
that referenced
this pull request
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of spyder-ide/spyder#22412