PR: Build conda package and add workflow #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mrclary
commented
Mar 28, 2025
mrclary
commented
- Remove interactivity from scripts
- Add executable script at install
- Use absolute imports
- Move source code to src directory
- Add conda recipe
- Add workflow
This will be more conducive to executable script
Note: argv removed from main call signature to be compatible with executable script created at install. argparser should handle sys.argv automatically.
mrclary
force-pushed
the
update-scripts
branch
13 times, most recently
from
c4aa009 to
18b495b
Compare
This is compatible with recipe directory in repository.
ccordoba12
reviewed
Apr 5, 2025
Member
ccordoba12
left a comment
ccordoba12
left a comment
There was a problem hiding this comment.
Thanks @mrclary for your work on this!
mrclary
commented
Apr 5, 2025
mrclary
commented
Apr 5, 2025
mrclary
commented
Apr 5, 2025
mrclary
commented
Apr 5, 2025
Collaborator
Author
|
@ccordoba12, looks like the suggestions are all okay. I checked the new artifacts locally. |
Co-authored-by: Carlos Cordoba <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.