PR: Use a more fine-grained name to detect if Spyder is running

[ccordoba12]

Right now we're using pgrep spyder to check if Spyder is still running before starting the update.

However, that matches the command used to run the updater on Linux, which in my case is:

/home/carlos/.local/spyder-6/envs/spyder-updater/bin/python3.13 /home/carlos/.local/spyder-6/envs/spyder-updater/bin/spyder-updater --update-info-file /tmp/spyder-carlos/updates/6.1.0rc1/update-info.json --start-spyder

And that makes the updater wait indefinitely for itself to be closed.

So, if we use pgrep spyder-runtime, we shouldn't have this problem.

[mrclary]

Hmm... on macOS pgrep spyder-runtime does not return anything, while pgrep spyder returns the Spyder process. Interestingly, ps -ef | grep spyder-runtime and ps -ef | grep spyder return the same results.

[ccordoba12]

Perhaps we should use then pgrep spyder-runtime for Linux and pgrep spyder for Mac?

[mrclary]

Perhaps we should use then pgrep spyder-runtime for Linux and pgrep spyder for Mac?

Okay, I think we can just use -f for both Linux and macOS. That is supposed to match against the full command, not just the process name. Can you confirm on linux?

pgrep -f spyder-runtime

and

pgrep -f spyder-updater

[mrclary]

Suggested change

	while [[ $(pgrep spyder-runtime 2> /dev/null) ]]; do
	while [[ $(pgrep -f spyder-runtime 2> /dev/null) ]]; do

[mrclary]

I think if we add the -f flag, then it will search the entire command instead of just the process name, so it should work for both macOS and Linux. This seemed to work for me on macOS; I could isolate and distinguish between Spyder and Spyder updater.

[ccordoba12]

Sorry, this fails for me on Linux (i.e. I get the same behavior as with pgrep spyder).

[ccordoba12]

However, this works, which I think it's better

Suggested change

	while [[ $(pgrep spyder-runtime 2> /dev/null) ]]; do
	while [[ $(pgrep -f spyder-runtime/bin 2> /dev/null) ]]; do

[mrclary]

That's interesting; I wonder why /bin works but sans /bin does not? Anyway, this appears to work on macOS as well, so it should be good.