Add title to comparison section in the home page and improve its graphic #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for spyder-website-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Member
|
Thanks for the quick response Andrés! I only have a small comment: do you think we should add the v-shaped separator between the hero and this new section? |
Collaborator
Author
|
I added an optional divider to the hero section. Let me know what you think. |
Member
|
Looks really good to me, thanks @conradolandia! I think the page looks more consistent that way, which is nice. However, the name for that section is not that good, so let's wait to hear from @CAM-Gerlach about it. |
ccordoba12
changed the title
ccordoba12
reviewed
Oct 26, 2024
ccordoba12
changed the title
…pyder-website into title-comparison
ccordoba12
approved these changes
Oct 31, 2024
Member
ccordoba12
left a comment
ccordoba12
left a comment
There was a problem hiding this comment.
Looks good to me now, thanks @conradolandia!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.