PR: Remove dependency on atomicwrites
#24698
Open
+116
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ccordoba12
changed the title
atomicwrites
dalthviz
previously approved these changes
Jul 10, 2025
Member
dalthviz
left a comment
dalthviz
left a comment
There was a problem hiding this comment.
Thank you @mathstuf for your work here! Gave this a check and seems like things are working as expected 👍
Also, to check this, I gave a check to the atomicwrites repo and one thing that maybe could be nice to add to this PR is some sort of version of the tests available there. Not completly sure if that's actually worthy to be honest but what do you think @ccordoba12 ?
Besides that this LGTM so leaving approved
mathstuf
force-pushed
the
no-atomicwrites
branch
from
f30a928 to
3ea498d
Compare
Author
|
I added the test suite; let's see how it runs in CI. |
Member
Thanks for that @mathstuf! It's really cool to have some tests for this functionality. |
mathstuf
force-pushed
the
no-atomicwrites
branch
from
3ea498d to
3032a21
Compare
The package has been deprecated. Replace usage with open-coded replacement. Also copy the test suite for the function. Lifted from pimutils/khal#1393 (which I also authored). Fixes: spyder-ide#24689
mathstuf
force-pushed
the
no-atomicwrites
branch
from
3032a21 to
f09c004
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Included a screenshot or animation (if affecting the UI, see Licecap)The package has been deprecated. Replace usage with open-coded replacement.
Lifted from pimutils/khal#1393 (which I also authored).
Issue(s) Resolved
Fixes #24689
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: mathstuf