PR: Use NSIS template to launch Spyder after installer completes - #26264
Open
mrclary wants to merge 7 commits into
Open
PR: Use NSIS template to launch Spyder after installer completes#26264mrclary wants to merge 7 commits into
mrclary wants to merge 7 commits into
Conversation
Added option to update the uninstaller shortcut file. Added option to only build the installer. Ensure build directory exists for each action independently.
2 tasks
mrclary
marked this pull request as ready for review
August 15, 2026 03:05
mrclary
changed the title
mrclary
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
constructorintroduced new stdout/stderr handling to improve installer logging.This disrupted our current
post-install.batin two ways:install.logis no longer compatible.step.logfile handle resulting in aPermissionErrorThis PR replaces the
post-install.batscript with a patched NSIS template.The sole purpose of the post-install script was to invoke a process that watched for the installer to complet and then launch Spyder. However, NSIS provides this feature.
We now maintain a patch that is applied to a copy of
constructor'smain.nsi.tmpldefault template at build time. The patch adds the Spyder application launch logic to the Windows installer.The other platforms remain the same, and silent installs will not launch Spyder.
Issue(s) Resolved
Fixes #26259
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: