Skip to content

Run typechecking in CI #843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 18, 2025
Merged

Conversation

nwalters512
Copy link
Contributor

The upgrades to Jest-related packages were the easiest solution to fix this type error that occurred when yarn ts:check was run on master:

node_modules/@jest/environment/build/index.d.ts:327:26 - error TS2430: Interface 'JestImportMeta' incorrectly extends interface 'ImportMeta'.
  The types returned by 'jest.createMockFromModule(...)' are incompatible between these types.
    Type 'unknown' is not assignable to type 'T'.
      'T' could be instantiated with an arbitrary type which could be unrelated to 'unknown'.

327 export declare interface JestImportMeta extends ImportMeta {
                             ~~~~~~~~~~~~~~


Found 1 error in node_modules/@jest/environment/build/index.d.ts:327

Jest 29 changed the default snapshot version (see https://jestjs.io/docs/upgrading-to-jest29#snapshot-format). I updated the existing snapshots to use that. I'd also be happy to change the Jest config if you wanted to minimize the diff.

Copy link

codesandbox-ci bot commented Mar 16, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@nene nene merged commit 1882ff2 into sql-formatter-org:master Mar 18, 2025
2 checks passed
@nene
Copy link
Collaborator

nene commented Mar 18, 2025

Thanks for that. Works great. ❤️

@nwalters512 nwalters512 deleted the ci-typecheck branch March 18, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants