-
Notifications
You must be signed in to change notification settings - Fork 422
fix: cjs using .js extension #846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, good job!
Can somebody wake the maintainers up?! I kind of need this asap? |
Huh... this 15.5.0 release went quite bad. Thanks for the patch. |
I had no idea so many people are depending on this little tool. Released the fix in 15.5.1. |
Another fireship video? 😄 |
well, firebase-tools has dependency on this package and this morning was more refreshing than any coffee :) |
We are still getting many errors like
It's all fine for 15.4, but if we start getting these errors from 15.5. Also tried 15.6 and still same issue. Do we know if it is related to the 15.0 release? 🤔 PS: We are using Webpack for bundling. |
Well, this specific pull request only fixes a problem caused by 15.5.0 release, which was obviously broken. The main change really happened in #842 If you do have a problem, please report a bug and try to create some sort of way to reproduce it. |
fix #845