Fix: SQLite STRICT is not propagated in batch mode (#1758)#1792
Open
khanjan2708 wants to merge 1 commit intosqlalchemy:mainfrom
Open
Fix: SQLite STRICT is not propagated in batch mode (#1758)#1792khanjan2708 wants to merge 1 commit intosqlalchemy:mainfrom
khanjan2708 wants to merge 1 commit intosqlalchemy:mainfrom
Conversation
…my#1758) Introduced a new hook autogen_table_reflect in DefaultImpl to allow dialect-specific metadata adjustment after reflection. In SQLiteImpl, this hook parses sqlite_master to detect and persist STRICT and WITHOUT ROWID properties when recreating tables in batch mode. Added regression tests in tests/test_batch.py.
Member
|
hi, this PR has a lot of formatting changes. thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1758
Description
This PR addresses Issue #1758 where SQLite tables created with special keywords like
STRICTorWITHOUT ROWIDlost these properties whenever a batch migration was performed (e.g., dropping a column or changing a type).Since SQLAlchemy's standard reflection does not currently capture these SQLite-specific table arguments, Alembic's batch mode would "forget" them when recreating the table.
Checklist
This pull request is:
must include a complete example of the issue. one line code fixes without an
issue and demonstration will not be accepted.
Fixes: #<issue number>in the commit messageinclude a complete example of how the feature would look.
Fixes: #<issue number>in the commit messageHave a nice day!