Skip to content
This repository has been archived by the owner on Sep 17, 2023. It is now read-only.

Add GitHub Actions workflow that check SQLite release #1

Merged
merged 2 commits into from
Mar 25, 2023
Merged

Conversation

lucydodo
Copy link
Member

This patch checks for the latest version of SQLite and patches the formula if SQLite has been updated.
This PR related to discussion #3297

Workflow work conditions

  • Every Sunday at 00:00 UTC
  • Manual

Notes: 00:00 UTC is estimated to be a high load time for GitHub Actions workflow execution.
As a result, it may run later than 00:00 (Further information)

Test results (Fork)

When the workflow confirm for a new release of SQLite

Screenshot 2023-03-25 at 11 44 43
Action generates a commit for the new release of SQLite. (https://github.com/lucydodo/homebrew-sqlite3/commit/ea5b54cd9d1788814e28f841dc61ec8679dcbfb2 / Job)

When the workflow confirm for a no new release of SQLite

Screenshot 2023-03-25 at 11 48 50
We can see that the workflow skips the 'Commit and Push' job. (Job)

Required action before merge PR

In Settings -> Actions, set the following:

  • Code and automation -> Actions -> General
    • Actions permissions: Allow all actions and reusable workflows
    • Workflow permissions: Read and write permissions

Please feel free to review it. Thanks! 😄

@lucydodo lucydodo added the enhancement New feature or request label Mar 25, 2023
@lucydodo lucydodo requested a review from justinclift March 25, 2023 03:10
@lucydodo lucydodo self-assigned this Mar 25, 2023
@justinclift
Copy link
Member

This looks good to me. Lets have it check every day though instead of just once a week.

Once it's merged, we'll need to comment out the bottle section of the formula too so Homebrew doesn't keep on trying to use the (old) bottles. 😄

@justinclift justinclift merged commit e8b8f32 into sqlitebrowser:master Mar 25, 2023
@justinclift
Copy link
Member

k, I just hit the button. Are you ok to take care of the settings changes? 😄

@lucydodo
Copy link
Member Author

Sure! Go ahead.

@justinclift
Copy link
Member

I've just removed the "bottles" section from the SQLite formula. I'll leave the Settings changes to you. 😄

@justinclift
Copy link
Member

In theory, if we check back tomorrow then the formula should be updated for SQLite 3.41.2, like in your fork. 😄

@lucydodo
Copy link
Member Author

Unfortunately, I don't have access to the settings :(

@lucydodo
Copy link
Member Author

That's right, it's about 19 hours away, which may be a little late as mentioned above.

@justinclift
Copy link
Member

Unfortunately, I don't have access to the settings :(

k, try again now. I didn't realise this repo wasn't in our Developers membership list. So, I've just added it. You should have Admin access now. 😄

@lucydodo
Copy link
Member Author

Confirmed. I have admin access now. 😄
Screenshot 2023-03-25 at 14 08 59
And as you can see, the Action workflow is queued up just fine!

@justinclift
Copy link
Member

Awesome, great work @lucydodo.

You've saved me a bunch of work with this one, and made sure these nightly builds are always fresh too. 😄

@lucydodo
Copy link
Member Author

Haha I'm glad it helped.

@lucydodo
Copy link
Member Author

Interesting to note: About 55 minutes ago, it was midnight UTC, so I was waiting for the workflow to work.
In my fork, workflow started working around 00:20 UTC. However, it's still not working 55 minutes later for here.

For now, let's wait a big longer.

@lucydodo
Copy link
Member Author

lucydodo commented Mar 26, 2023

The workflow ran fine 26 minutes ago. (https://github.com/sqlitebrowser/homebrew-sqlite3/actions/runs/4522027340)
I also verified that SQLite updates were working properly. (0f4859b) 😄 There was a delay of about an hour.

@justinclift
Copy link
Member

Awesome. Timing wise, with it running pretty much any time each day should be fine. 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants