better error handling for csrs#211
Merged
Merged
Conversation
Error when no valid certs are found when verifying instead of accessing oob Warn when CSRs are found instead of silently ignoring them
alokmenghrajani
approved these changes
Feb 25, 2020
alokmenghrajani
left a comment
alokmenghrajani
left a comment
Contributor
There was a problem hiding this comment.
nit: add a test? Also, how much work would it be to parse CSRs?
Contributor
Author
|
seems like theres already a PR to add CSR support but seems abandoned #203 |
alokmenghrajani
approved these changes
Feb 25, 2020
alokmenghrajani
left a comment
alokmenghrajani
left a comment
Contributor
There was a problem hiding this comment.
I'm fine merging this or trying to revive #203.
mbyczkowski
approved these changes
Feb 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In reference to issue #177
Error when no valid certs are found when verifying instead of accessing oob
Warn when CSRs are found instead of silently ignoring them