Add support for anonymous functions - #479
Open
Egorand wants to merge 1 commit into
Open
Conversation
JakeWharton
approved these changes
Sep 22, 2018
|
|
||
| @JvmStatic fun unnamed(type: TypeName) = Builder("", type).build() | ||
|
|
||
| @JvmStatic fun untyped(name: String) = Builder(name, null).build() |
Collaborator
There was a problem hiding this comment.
I'm a bit skeptical about needing to support this. Can we leave it out and see if anyone ever complains?
swankjesse
approved these changes
Oct 14, 2018
|
|
||
| internal val String.isConstructor get() = this == CONSTRUCTOR | ||
| internal val String.isAccessor get() = this.isOneOf(GETTER, SETTER) | ||
| internal val String?.isConstructor get() = this == CONSTRUCTOR |
Collaborator
Author
There was a problem hiding this comment.
..although technically this is what String.equals() already does, but semantically I like === better
Egorand
force-pushed
the
egorand/0916/anonymous-functions
branch
from
October 14, 2018 01:06
b791061 to
bd06fc1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #474