Say that docs/api is git ignored rather than committed - #2940
Merged
Conversation
AGENTS.md claimed docs/api was Dokka output committed to the repo. It has been git ignored since 5abae5d ("Prepare 2.9 release", April 2022), which untracked every docs/api file and added the directory to .gitignore in the same commit. Both release guides already have this right: they run `rm -rf docs/api && ./gradlew siteDokka` before `mkdocs gh-deploy` precisely because the directory isn't there. That line sent me looking for a directory to regenerate after a public API change in #2938, which is the exact failure this file exists to prevent. Moved out of "Things that will bite you" and onto the siteDokka command, next to updateKotlinAbi. Nothing about a generated, ignored directory is surprising once stated, so it isn't a bite; the useful moment for the fact is when you've just changed the public API and are deciding what to regenerate. Kept the half of the warning that still holds — fix the KDoc, not the generated pages. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
dayanruben
pushed a commit
to dayanruben/leakcanary
that referenced
this pull request
Aug 6, 2026
`main` is deliberately unprotected, so it has no required status checks. Auto-merge is enabled at the repo level, which makes `gh pr merge --auto` look like the way to land a PR once CI passes, but with nothing to gate on GitHub merges on the spot — exiting zero and printing nothing, so it reads exactly like it armed. I merged square#2940 that way with eleven emulator jobs still pending. Leaving `main` open is deliberate and worth keeping, so the fix is to document the wait that actually works rather than to protect the branch: `gh pr checks --watch --fail-fast && gh pr merge`, started detached because a run takes 9 to 13 minutes and a ten minute foreground timeout lands right before the last emulator reports. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AGENTS.md claimed
docs/apiwas Dokka output committed to the repo. It has been git ignored since5abae5d77("Prepare 2.9 release", April 2022), which untracked everydocs/apifile and added the directory to.gitignorein the same commit.git ls-files docs/apireturns nothing and the directory does not exist in a fresh clone.Both release guides already have this right —
docs/releasing.md:155anddocs/releasing-shark-explorer.md:81runrm -rf docs/api && ./gradlew siteDokkabeforemkdocs gh-deployprecisely because the directory is not there, and the shark-explorer guide states the reason in prose. Only AGENTS.md misstated it, so this is a docs correction, not a build change.That line sent me looking for a directory to regenerate after the public API change in #2938 — the exact failure this file exists to prevent.
Why it moved out of "Things that will bite you"
Nothing about a generated, git-ignored directory is surprising once stated, so it is not a bite. The moment the fact is actually useful is when you have just changed the public API and are deciding what to regenerate — which is next to
updateKotlinAbiin the command list. The contrast is the point:updateKotlinAbiproduces something you commit,siteDokkadoes not. The half of the old warning that still holds — fix the KDoc, not the generated pages — is kept.Rest of the file
Checked every other factual claim for the same kind of drift; all still hold:
checkKotlinAbi/updateKotlinAbi/siteDokka/installGitHooksall exist in the rootbuild.gradle.kts, and the two-mechanism explanation matches the Android hand-rolled tasks there.modulesWithoutPublicApiexists and is the exemption list described.settings.gradleand the directories on disk../gradlew build.HprofRetainedHeapPerfTestandHprofIOPerfTestare both inshark-android.config/detekt-config.yml, hook installed fromassembleandclean.assertjCore.androidpinned to 3.15.0 with the API 24 explanation in the catalog.shark/shark-exploreris the one scoped guide, pairedAGENTS.md+CLAUDE.mdas documented.One thing I noticed but did not change: the instrumentation-test sentence names four modules, and
samples/leakcanary-android-samplealso has anandroidTestsource set (one test). CI does not runconnectedCheckon it —.github/workflows/main.yml:108runs exactly the four modules listed — so the sentence is right about what CI covers. Flagging it in case you want the wording to distinguish "has instrumentation tests" from "CI runs them".🤖 Generated with Claude Code