Rename Shark Explorer to Shark Dive - #2967
Merged
Merged
Conversation
"Explorer" said the app was for looking around a heap dump, which is what it was. It now records verdicts, keeps notes and answers an agent over MCP: an investigation rather than a browse. A dive is the thing you go on, it is what the shark was already doing, and it says nothing about a window. The rename is everything the app is named in: the five modules and their Gradle paths, the shark.explorer package, the macOS bundle and its shark:// scheme handler, the release workflows and their tag prefix, the docs and the agent skill. Nothing has ever been released under the old name — no shark-explorer-* tag and no GitHub release — so no artifact, tag or installed copy is orphaned by it, and there is no migration code for the same reason: ~/.shark-explorer becomes ~/.shark-dive by hand, on the handful of machines that have run it from source. LeakCanary's own on-device HprofExplorerScreen keeps its name. It predates this app and is a different feature. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"Explorer" said the app was for looking around a heap dump, which is what it was. It now records verdicts, keeps notes and answers an agent over MCP — an investigation rather than a browse. A dive is the thing you go on, it is what the shark was already doing, and it says nothing about a window.
The rename covers everything the app is named in: the five modules and their Gradle paths, the
shark.explorerpackage, the macOS bundle and itsshark://scheme handler, the release workflows and their tag prefix, the docs, and the agent skill.Nothing has ever been released under the old name — no
shark-explorer-*tag and no GitHub release — so no artifact, tag or installed copy is orphaned, and there is no migration code for the same reason.~/.shark-explorerbecomes~/.shark-diveby hand, on the handful of machines that have run it from source.LeakCanary's own on-device
HprofExplorerScreenkeeps its name. It predates this app and is a different feature, so it is deliberately untouched, as is the 2019 changelog entry that announced it.No changelog entry. The whole of Shark Dive's
## Unreleasedis the initial release, so an entry saying it was renamed would tell readers of 1.0.0 that something they never had changed name.A catch phrase went into the agent section of the docs, since that is where it lands:
./gradlew buildpasses, and the five modules' 863 tests are green with detekt clean.🤖 Generated with Claude Code