Don't crash route selection when the system proxy selector throws#9478
Open
SAY-5 wants to merge 1 commit into
Open
Don't crash route selection when the system proxy selector throws#9478SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9469.
When no explicit proxy is configured,
RouteSelectorcallsaddress.proxySelector.select(uri)and only handles a null/empty return. On Android the platformDefaultProxySelectorcan itself throwIllegalArgumentException: port out of range:-1when a system proxy is configured (via APN/MDM) with an unset port. That exception propagates out ofresetNextProxyand crashes the call on the dispatcher thread, even though OkHttp already rejects out-of-range proxy ports elsewhere.This treats a throwing
ProxySelector.select()the same as a null/empty result and falls back to a direct connection, which matches how the surrounding code already handles "no usable proxy". Added aRouteSelectorTestcase that fails on the current code and passes with the fix.