Skip to content

Initial attempt at internalizing self-approval into the plugin #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
stouset wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Initial attempt at internalizing self-approval into the plugin #36

stouset wants to merge 4 commits into from
+201 −96

Conversation

@stouset
Copy link
Collaborator

@stouset stouset commented Jun 28, 2018

No description provided.

@stouset stouset requested a review from mcpherrinm as a code owner June 28, 2018 19:23
@stouset stouset force-pushed the determine-pair-euid branch 5 times, most recently from e727670 to 91c763d Compare June 28, 2018 20:28
@stouset stouset force-pushed the determine-pair-euid branch 5 times, most recently from 0cc456e to ac86e85 Compare July 12, 2018 20:40
@stouset stouset force-pushed the determine-pair-euid branch 2 times, most recently from f30489a to 4d19c60 Compare July 12, 2018 20:50
@stouset stouset force-pushed the determine-pair-euid branch from 4d19c60 to 23fc9d0 Compare July 12, 2018 21:11
@stouset
Copy link
Collaborator Author

stouset commented May 5, 2020

Very important that users can't just sudo -u $user /path/to/approval/script to bypass this. We may need to have two scripts, one for the authenticated side and one for the unauthenticated side. But that means extra hassle for teams deploying this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcpherrinm mcpherrinm Awaiting requested review from mcpherrinm

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stouset