Adding wasm target to wire runtime.#3304
Merged
mpawliszyn merged 2 commits intomasterfrom Mar 19, 2025
Merged
Conversation
mpawliszyn
force-pushed
the
mikepaw.wasm
branch
from
517db50 to
2abb8b2
Compare
oldergod
approved these changes
Mar 17, 2025
Member
|
Related PR: #3152 |
mpawliszyn
force-pushed
the
mikepaw.wasm
branch
from
2abb8b2 to
ce13a51
Compare
Collaborator
|
Yeah I have similar concerns as #3152 (comment), although this seems less duplicate-y but HMPP should eliminate it entirely. And we should really add both targets... |
mpawliszyn
force-pushed
the
mikepaw.wasm
branch
2 times, most recently
from
8a5e4fd to
1cb479e
Compare
Collaborator
Author
|
@JakeWharton I think I managed to massage it into a more Hierarchical Multi-Platform Project. WDYT? |
mpawliszyn
force-pushed
the
mikepaw.wasm
branch
6 times, most recently
from
cd4eb82 to
c104a4c
Compare
mpawliszyn
force-pushed
the
mikepaw.wasm
branch
from
c104a4c to
5eb63ae
Compare
JakeWharton
approved these changes
Mar 19, 2025
Collaborator
JakeWharton
left a comment
JakeWharton
left a comment
There was a problem hiding this comment.
Hell yeah! Great work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3152.