More clever failing related to target and source presence #3307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oldergod
commented
Mar 31, 2025
Comment on lines
+258
to
+263
| if (targets.isEmpty() && fullSchema.protoFiles.all { isWireRuntimeProto(it.location) }) { | ||
| // We have sources but no target to handle them. | ||
| IllegalStateException("Sources have been found but no target are set. " + | ||
| "At least one target must be provided for this project\n" + | ||
| "See our documentation for details: https://square.github.io/wire/wire_compiler/#customizing-output") | ||
| } |
There was a problem hiding this comment.
It doesn't look like this code is executed on neither of the tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.