Use Gradle properties in nested Wire output DSL#3582
Draft
steve-the-edwards wants to merge 1 commit intomasterfrom
Draft
Use Gradle properties in nested Wire output DSL#3582steve-the-edwards wants to merge 1 commit intomasterfrom
steve-the-edwards wants to merge 1 commit intomasterfrom
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-019dd082-b0e1-733a-b22f-58154ad76309 Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I recently had this issue - #3543 - but for the inner Custom Schema Handler DSL.
So I thought we could extend this type of solution - #3570 - to the DSL for this as well.
We need to keep them as Output's for as long as possible before converting to Target so that we can bring the Gradle Property/Provider plumbing through.